Skip to content

Add flake8 check to Travis#112

Merged
linsomniac merged 1 commit intolinsomniac:masterfrom
timgraham:flake8
Dec 17, 2016
Merged

Add flake8 check to Travis#112
linsomniac merged 1 commit intolinsomniac:masterfrom
timgraham:flake8

Conversation

@timgraham
Copy link
Copy Markdown
Collaborator

No description provided.

@timgraham timgraham force-pushed the flake8 branch 2 times, most recently from 5815810 to 092836c Compare December 16, 2016 13:30
@timgraham
Copy link
Copy Markdown
Collaborator Author

timgraham commented Dec 16, 2016

Other warnings from hacking (causing the build failure):

./memcache.py:783:1: H404  multi line docstring should start without a leading new line
./memcache.py:783:1: H405  multi line docstring summary not separated with an empty line
./tests/test_memcache.py:7:28: H301  one import per line
./tests/test_memcache.py:37:11: H101  Use TODO(NAME)

I'm not sure they provide much value. If I were maintaining the package I'd remove hacking from test dependencies and not worry about those warnings. Other opinions?

@linsomniac linsomniac merged commit ea0cb51 into linsomniac:master Dec 17, 2016
@linsomniac
Copy link
Copy Markdown
Owner

Thanks for the PR, I think it's worth some clean up, I'll work on that.

linsomniac pushed a commit that referenced this pull request Dec 17, 2016
@linsomniac
Copy link
Copy Markdown
Owner

@timgraham : I fixed up the things it was reporting, but it is failing on py33 with an error that looks entirely related to Travis/tox/flake8:

  File "/home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages/hacking/checks/except_checks.py", line 71, in is_none
    return isinstance(node, ast.NameConstant) and node.value is None
AttributeError: 'module' object has no attribute 'NameConstant'

Any ideas?

@timgraham timgraham deleted the flake8 branch December 18, 2016 11:20
@timgraham
Copy link
Copy Markdown
Collaborator Author

Looks like ast.NameConstant is new in Python 3.4 so it's a bug in hacking if they claim to support Python 3.3. We could try to skip flake8 on Python 3.3 or just drop support for Python 3.3 entirely -- I don't think it's used much anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants